Unify selecting constraints option when installing airflow #52274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will have to test it also with "upgrade with newer dependencies" and "canary" before I merge it. |
|
Ok - now I have consistent at least (and failing) - and can fix it :) |
Due to the way how it historically got added - we had two ways of selecting whether we are installing airlfow dyanmically in breeze with or without constraints: * --install-airflow-with-constraints - was used in a few places * --skip-airflow-constraints - was used in other places The logic to handle those were broken at places where they contradicted each other. This PR unifies it and only uses the --install-airflow-with-constraints flag in all the places where we need to determine whether constraints are used or not and it fixes the logic. The logic of installation had been reviewed, refactored into separate methods doing smaller tasks and more diagnostics was added.
3ca47a0 to
4474d0f
Compare
|
I refactored the installation script and split the long and complex method into smaller, separate methods doing things in much easiert to understand way. |
potiuk
commented
Jun 26, 2025
eladkal
approved these changes
Jun 26, 2025
|
Let me try with |
|
Indeed seems like it is going to be easier to understand it now - also for me :) |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 8846bef v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 26, 2025
apache#52274) Due to the way how it historically got added - we had two ways of selecting whether we are installing airlfow dyanmically in breeze with or without constraints: * --install-airflow-with-constraints - was used in a few places * --skip-airflow-constraints - was used in other places The logic to handle those were broken at places where they contradicted each other. This PR unifies it and only uses the --install-airflow-with-constraints flag in all the places where we need to determine whether constraints are used or not and it fixes the logic. The logic of installation had been reviewed, refactored into separate methods doing smaller tasks and more diagnostics was added. (cherry picked from commit 8846bef) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 26, 2025
apache#52274) Due to the way how it historically got added - we had two ways of selecting whether we are installing airlfow dyanmically in breeze with or without constraints: * --install-airflow-with-constraints - was used in a few places * --skip-airflow-constraints - was used in other places The logic to handle those were broken at places where they contradicted each other. This PR unifies it and only uses the --install-airflow-with-constraints flag in all the places where we need to determine whether constraints are used or not and it fixes the logic. The logic of installation had been reviewed, refactored into separate methods doing smaller tasks and more diagnostics was added. (cherry picked from commit 8846bef) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 26, 2025
apache#52274) Due to the way how it historically got added - we had two ways of selecting whether we are installing airlfow dyanmically in breeze with or without constraints: * --install-airflow-with-constraints - was used in a few places * --skip-airflow-constraints - was used in other places The logic to handle those were broken at places where they contradicted each other. This PR unifies it and only uses the --install-airflow-with-constraints flag in all the places where we need to determine whether constraints are used or not and it fixes the logic. The logic of installation had been reviewed, refactored into separate methods doing smaller tasks and more diagnostics was added. (cherry picked from commit 8846bef) Co-authored-by: Jarek Potiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way how it historically got added - we had two ways of selecting whether we are installing airlfow dyanmically in breeze with or without constraints:
The logic to handle those were broken at places where they contradicted each other. This PR unifies it and only uses the --install-airflow-with-constraints flag in all the places where we need to determine whether constraints are used or not and it fixes the logic.
The logic of installation had been reviewed, refactored into separate methods doing smaller tasks and more diagnostics was added.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.