-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Build python from source #52265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Build python from source #52265
Conversation
Builds python from source, also installs golang from official distribution. Does both of these for the ci image only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and is IMHO "fast enough" - enough to merge and try it even now in CI image
Adds support for using the airflow api to fetch the newest python patch version available for specific major_minor pair
@@ -292,6 +292,7 @@ jobs: | |||
if: always() | |||
env: | |||
UPGRADE_UV: "true" | |||
UPGRADE_PYTHON: "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in slack it would also be great to add golang here - in the fashion similar to UV - we do not "fail" the build when uv has new version - we merely print the output showing that it should be upgraded, but when we run pre-commit locally we use defaults - which means we update everything. That is the best of both worlds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice - with one caveat only - that we should add golang in a similar fashion as uv
closes: #52106
Builds python from source, also installs
golang from official distribution. Does
both of these for the ci image only.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.