Skip to content

Build python from source #52265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aritra24
Copy link
Collaborator

@aritra24 aritra24 commented Jun 25, 2025

closes: #52106

Builds python from source, also installs
golang from official distribution. Does
both of these for the ci image only.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Builds python from source, also installs
golang from official distribution. Does
both of these for the ci image only.
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch labels Jun 25, 2025
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and is IMHO "fast enough" - enough to merge and try it even now in CI image

aritra24 added 2 commits June 30, 2025 22:56
Adds support for using the airflow api to fetch
the newest python patch version available for specific
major_minor pair
@aritra24 aritra24 marked this pull request as ready for review June 30, 2025 17:38
@aritra24 aritra24 changed the title Draft: Build python from source Build python from source Jun 30, 2025
@@ -292,6 +292,7 @@ jobs:
if: always()
env:
UPGRADE_UV: "true"
UPGRADE_PYTHON: "false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in slack it would also be great to add golang here - in the fashion similar to UV - we do not "fail" the build when uv has new version - we merely print the output showing that it should be upgraded, but when we run pre-commit locally we use defaults - which means we update everything. That is the best of both worlds.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice - with one caveat only - that we should add golang in a similar fashion as uv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change sources of our docker images
2 participants