Remove side-effects in plugin manager tests #52258
Merged
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess CI must not run this exact combination of tests together, but prior to this change if you ran `pytest airflow-core/tests/unit/models/test_dag.py::TestDag::test_bulk_write_to_db_assets airflow-core/tests/unit/plugins/test_plugins_manager.py::TestPluginsManager::test_registering_plugin_listeners` you would get a test failure. The issue was caused by having two fixtures of the same name, a module level `clean_plugins`, and a class level one. This is by design in Pytest and is how to override plugins at different scopes. This also explains why we had `listener_manager.clear()` in a finally block when it should have been handled by the fixture
kaxil
approved these changes
Jun 25, 2025
|
Nice. I think a lot depends on sequence of executions and cleanups it between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess CI must not run this exact combination of tests together, but prior to
this change if you ran
pytest airflow-core/tests/unit/models/test_dag.py::TestDag::test_bulk_write_to_db_assets airflow-core/tests/unit/plugins/test_plugins_manager.py::TestPluginsManager::test_registering_plugin_listenersyou would get a test failure.
The issue was caused by having two fixtures of the same name, a module level
clean_plugins, and a class level one. This is by design in Pytest and is howto override plugins at different scopes.
This also explains why we had
listener_manager.clear()in a finally blockwhen it should have been handled by the fixture