Add React Apps to plugin #52255
Merged
Add React Apps to plugin #52255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f66ebd to
b7fd1b6
Compare
bbovenzi
reviewed
Jun 25, 2025
bbovenzi
reviewed
Jun 25, 2025
bbovenzi
reviewed
Jun 25, 2025
6c8dd23 to
ece7548
Compare
ece7548 to
9e7dd24
Compare
bbovenzi
approved these changes
Jun 26, 2025
jscheffl
reviewed
Jun 26, 2025
| class ExternalViewResponse(BaseUIResponse): | ||
| """Serializer for External View Plugin responses.""" | ||
|
|
||
| model_config = ConfigDict(extra="allow") |
There was a problem hiding this comment.
Why actually do we allow extras here?
There was a problem hiding this comment.
This is how plugin attributes are built, every members of the Plugin allow extra attributes and are serialized and returned. This was the behavior in 2.x, so we kept the same parttern in 3.x. Newly added attributes (react_apps, fastapi_apps, eternal_views) also follow the same pattern.
Meaning that you can attach some extra metadata to your plugin members, and it will be returned by the API.
|
Late to the party to review - COOL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #42702
Add 'react_apps` registration to plugin. This will be used by the front-end to fetch bundles and dynamically import related components.