Fix logical_date handling for using exeuction_date_fn in ExternalTaskSensor
#52237
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logical date handling for the ExternalTaskSensor by updating the usage of execution_date_fn.
- Passes logical_date as an explicit parameter to _handle_execution_date_fn rather than extracting it from the context
- Updates the function signature and removes the redundant extraction of logical_date from the context
Comments suppressed due to low confidence (1)
providers/standard/src/airflow/providers/standard/sensors/external_task.py:532
- Update the docstring for _handle_execution_date_fn to include and describe the new 'logical_date' parameter, ensuring the documentation accurately reflects the updated function signature.
def _handle_execution_date_fn(self, logical_date, context) -> Any:
33549ca to
c68ed07
Compare
bugraoz93
reviewed
Jun 25, 2025
| @@ -529,7 +529,7 @@ def get_external_task_group_task_ids(self, session, dttm_filter): | |||
| dttm_filter, self.external_task_group_id, self.external_dag_id, session | |||
| ) | |||
|
|
|||
| def _handle_execution_date_fn(self, context) -> Any: | |||
| def _handle_execution_date_fn(self, logical_date, context) -> Any: | |||
There was a problem hiding this comment.
I think this method is purely for backwar compatibility and shouldn't have this breaking change here
cc: @kaxil what do you think?
There was a problem hiding this comment.
@bugraoz93 Thanks for review.
IMO, the backward compatibility is already handled in caller function, it is better to keep consistent and align with the caller.
c68ed07 to
34da955
Compare
34da955 to
3576530
Compare
|
TBR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #52236