Skip to content

Clean up remaining DB-dependent tests from OpenSearch provider #52235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kyungjunleeme
Copy link
Contributor

Part of #52020


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

--- related with #52213

@kyungjunleeme kyungjunleeme marked this pull request as draft June 25, 2025 10:17
@kyungjunleeme kyungjunleeme marked this pull request as ready for review June 25, 2025 10:19
@kyungjunleeme kyungjunleeme marked this pull request as draft June 25, 2025 10:19
@kyungjunleeme kyungjunleeme force-pushed the remove-leftover-db-tests-from-opensearch branch from aa33924 to 3d38483 Compare June 25, 2025 10:28
@kyungjunleeme kyungjunleeme marked this pull request as ready for review June 25, 2025 10:46
@potiuk
Copy link
Member

potiuk commented Jun 25, 2025

Sorry - opensearch already done :)

@potiuk potiuk closed this Jun 25, 2025
@kyungjunleeme
Copy link
Contributor Author

kyungjunleeme commented Jun 25, 2025

@potiuk
hello, I'm trying to status from db tests left to cleaned

Is really finished?

opensearch - Remove db tests from opensearch provider #52213 - db tests left

@potiuk
Copy link
Member

potiuk commented Jun 25, 2025

Ah .. OK then :) sorry.

@potiuk
Copy link
Member

potiuk commented Jun 25, 2025

BTW. We will do a separate thing about getting rid of potentially "all" db_tests as next step - this might involve much heavier refaactorings - for example splitting out executors and providers that do need db. For now we are focusing only on "easy" cleanups - but of course - if you want to remove all of them now - you are absolutely free.

@kyungjunleeme
Copy link
Contributor Author

kyungjunleeme commented Jun 25, 2025

@potiuk Sure, thanks for the heads-up. I'll keep that in mind!

I'll participate in next step. #42632

@kyungjunleeme kyungjunleeme marked this pull request as draft June 25, 2025 13:33
@kyungjunleeme kyungjunleeme force-pushed the remove-leftover-db-tests-from-opensearch branch from 27c439a to 7152700 Compare June 25, 2025 13:35
@kyungjunleeme kyungjunleeme marked this pull request as ready for review June 25, 2025 13:35
@kyungjunleeme
Copy link
Contributor Author

Once the commits are cleaned up and ready, I’ll request a review.

@kyungjunleeme kyungjunleeme force-pushed the remove-leftover-db-tests-from-opensearch branch from 7152700 to d918c3f Compare June 25, 2025 23:25
…s in test_os_task_handler with @pytest.mark.db_test
@kyungjunleeme kyungjunleeme force-pushed the remove-leftover-db-tests-from-opensearch branch from d918c3f to e1634ba Compare June 26, 2025 00:55
@kyungjunleeme kyungjunleeme requested a review from potiuk June 26, 2025 01:58
@kyungjunleeme kyungjunleeme requested a review from choo121600 June 26, 2025 05:35
@kyungjunleeme
Copy link
Contributor Author

@potiuk hello, Could you review my pr?

@potiuk potiuk merged commit fda3fda into apache:main Jun 26, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants