Skip to content

Remove direct scheduler BaseOperator refs #52234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Remove direct scheduler BaseOperator refs #52234

wants to merge 9 commits into from
+655 −1,125

Conversation

uranusjr
Copy link
Member

They are either changed to SerializedBaseOperator or the SDK BaseOperator. If this works, we can work on combining the scheduler BaseOperator into SerializedBaseOperator, and remove SDK BaseOperator base references in the scheduler.

@uranusjr uranusjr force-pushed the remove-baseoperator-from-core branch 14 times, most recently from 3862cd8 to d297979 Compare June 30, 2025 05:58
@uranusjr uranusjr added the log exception Set the label if you want to accept change with caplog label Jun 30, 2025
@uranusjr uranusjr closed this Jun 30, 2025
@uranusjr uranusjr reopened this Jun 30, 2025
@uranusjr uranusjr force-pushed the remove-baseoperator-from-core branch 2 times, most recently from a832efd to f5dab1c Compare June 30, 2025 11:01
uranusjr added 8 commits July 1, 2025 14:52
@uranusjr
Remove direct scheduler BaseOperator refs
f5d43c6 
They are either changed to SerializedBaseOperator or the SDK
BaseOperator. If this works, we can work on combining the scheduler
BaseOperator into SerializedBaseOperator, and remove SDK BaseOperator
base references in the scheduler.
@uranusjr
Try to remove scheduler BaseOperator entirely
02ecc84 
We'll add compat shims later as needed
@uranusjr
Fine new homes for scheduler BaseOperator tests
ad8ee7b
@uranusjr
Fix dispatching to match inheritance
7519863
@uranusjr
Fix warning line number
f672e3e
@uranusjr
Move clear() for tests for now
9dfe929
@uranusjr
Fix test to use serialized dag and task
b15ce0e
@uranusjr
Correctly use real dag in test
45aa9db
@uranusjr uranusjr force-pushed the remove-baseoperator-from-core branch from f5dab1c to 5efe08c Compare July 1, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb Awaiting requested review from ashb ashb will be requested when the pull request is marked ready for review ashb is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil will be requested when the pull request is marked ready for review kaxil is a code owner

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh will be requested when the pull request is marked ready for review amoghrajesh is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk will be requested when the pull request is marked ready for review potiuk is a code owner

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan will be requested when the pull request is marked ready for review gopidesupavan is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy will be requested when the pull request is marked ready for review ephraimbuddy is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun will be requested when the pull request is marked ready for review pierrejeambrun is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar will be requested when the pull request is marked ready for review rawwar is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 will be requested when the pull request is marked ready for review jason810496 is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 will be requested when the pull request is marked ready for review bugraoz93 is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git will be requested when the pull request is marked ready for review shubhamraj-git is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin will be requested when the pull request is marked ready for review bolkedebruin is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG will be requested when the pull request is marked ready for review XD-DENG is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:serialization area:task-sdk log exception Set the label if you want to accept change with caplog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uranusjr