Skip to content

Remove db usage from http provider tests #52227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented Jun 25, 2025

Part of #52020. still some db refs left in sensors.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@gopidesupavan gopidesupavan force-pushed the fix-connection-http-provider branch from 785462b to 0ed7e04 Compare June 25, 2025 07:37
@potiuk
Copy link
Member

potiuk commented Jun 25, 2025

One tests fails :)

@gopidesupavan
Copy link
Member Author

One tests fails :)

Yeah on it :)

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Preemptively approving!

@potiuk
Copy link
Member

potiuk commented Jun 25, 2025

LAST ONE !

@gopidesupavan
Copy link
Member Author

LAST ONE !

Oh yeah, on it, lots of tests in http fixing PR will be in soon :)

@gopidesupavan
Copy link
Member Author

Anyone would like to take second pass? more refactoring in hook tests, still some db reference left from sensor those can be removed in next phases.

@gopidesupavan
Copy link
Member Author

CI is green..

@gopidesupavan gopidesupavan merged commit ccd7951 into apache:main Jun 25, 2025
71 checks passed
@gopidesupavan
Copy link
Member Author

oh @potiuk sorry didn't checked your reviewing

@gopidesupavan
Copy link
Member Author

happy to revert it and update PR , please let me know if any comments :)

@potiuk
Copy link
Member

potiuk commented Jun 26, 2025

No no all ok !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants