Fix: ensure get_df uses SQLAlchemy engine to avoid pandas warning #52224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
bugraoz93
reviewed
Jun 25, 2025
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py
Outdated
Show resolved
Hide resolved
providers/postgres/src/airflow/providers/postgres/hooks/postgres.py
Outdated
Show resolved
Hide resolved
bugraoz93
reviewed
Jun 30, 2025
| **kwargs, | ||
| ) -> PandasDataFrame | PolarsDataFrame: | ||
| """ | ||
| Execute the sql and returns a dataframe. |
There was a problem hiding this comment.
Maybe good to mention what type of dataframes it returns and add :return ...: ... as well into the doc :)
|
Thanks for the updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PostgresHook.get_df() warning when using non-SQLAlchemy connections
This PR updates the
PostgresHook.get_df()implementation to avoid triggering aUserWarningfrom pandas when the underlying connection is not an instance ofsqlalchemy.engine.Connection. The patch ensures better compatibility with non-SQLAlchemy connections and avoids log clutter during DAG execution.This change only affects the Postgres provider and does not alter the interface or behavior for existing users using SQLAlchemy-compatible connections.
closes: #52142
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.