Fix whitespace handling in DAG owners parsing for multiple owners #52216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jun 25, 2025
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Jun 25, 2025
…e owners (apache#52216) (cherry picked from commit b1be383) Co-authored-by: Yeonguk Choo <[email protected]>
pierrejeambrun
pushed a commit
that referenced
this pull request
Jun 25, 2025
…e owners (#52216) (#52221) (cherry picked from commit b1be383) Co-authored-by: Yeonguk Choo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When DAG owners are specified as comma-separated values with spaces (e.g., "owner1, owner2, owner3"), the FastAPI datamodel was not stripping whitespace, resulting in owners being parsed as ["owner1", " owner2", " owner3"] instead of ["owner1", "owner2", "owner3"].
Change
Modified get_owners method in DAGResponse to use
[x.strip() for x in v.split(",")]instead ofv.split(",")to properly handle whitespace around owner names.closes: #52215
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.