Skip to content

Revert "Add deprecation to airflow/sensors/base.py (#52178)" #52193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 24, 2025

This reverts commit 54f9bff.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Jun 24, 2025

Fixes failing main

@potiuk potiuk added the full tests needed We need to run full set of tests for this PR to merge label Jun 24, 2025
@potiuk potiuk closed this Jun 24, 2025
@potiuk potiuk reopened this Jun 24, 2025
@potiuk
Copy link
Member Author

potiuk commented Jun 24, 2025

Reopened with "full tests needed" - not sure if it fully "greens" main.

@potiuk
Copy link
Member Author

potiuk commented Jun 24, 2025

Reopened with "full tests needed" - not sure if it fully "greens" main.

Yes. It is likely also the reason for provider's mypy tests failing.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked how I can silence mypy and I have no good idea... reversion would be good.

@potiuk
Copy link
Member Author

potiuk commented Jun 24, 2025

Also checked how I can silence mypy and I have no good idea... reversion would be good.

Not only mypy - also tests are failing

@potiuk potiuk merged commit 11f1aa5 into apache:main Jun 24, 2025
118 of 123 checks passed
@potiuk potiuk deleted the revert-sensors-base-removal branch June 24, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants