Ignore mypy errors for deprecated executors #52187
Merged
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed SimpleTaskInstance in apache#52176 since it isn't used in Airflow 3. This caused failure in hybrid executors like `LocalKubernetesExecutor` and `CeleryKubernetesExecutor` -- which aren't suported in Airflow 3. Hence we can ignore mypy errors.
gopidesupavan
approved these changes
Jun 24, 2025
sunank200
approved these changes
Jun 24, 2025
|
do we need try catch import ? may be for compat tests? as its providers changes. |
Don't think so, since both the modules aren't supported for AF 3 |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 24, 2025
The apache#52187 added ignores in a bit wrong place due to auto-reformatting
potiuk
added a commit
that referenced
this pull request
Jun 24, 2025
The #52187 added ignores in a bit wrong place due to auto-reformatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed SimpleTaskInstance in #52176 since it isn't used in Airflow 3. This caused failure in hybrid executors like
LocalKubernetesExecutorandCeleryKubernetesExecutor-- which aren't suported in Airflow 3. Hence we can ignore mypy errors.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.