Skip to content

Fix GitDagBundle materialize version folder for DAG callbacks work (#52040) #52186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix GitDagBundle materialize version folder for DAG callbacks work (#52040) #52186

wants to merge 2 commits into from
+27 −0

Conversation

liyude-tw
Copy link

Problem

When GitDagBundle is used with supports_versioning=True, the DAG Processor
fails to execute DAG-level callbacks because the callback request points to
versions/<commit>/…, yet that folder does not exist (it is never materialised).

See #52040 for full context.

Fix

  • Extend GitDagBundle.refresh()
    • Detect a commit change after resetting the tracking repo.
    • Call the new helper function _materialize_version(commit) which:
      • ensures the bare repo exists and contains the commit
      • clones a work-tree into versions/<commit>
      • checks out the exact commit

Tests

  • Manual – verified in an Airflow 3.0.2 + GitLab environment (via the same
    logic as a monkey-patch): DAG callbacks now execute correctly.
  • Local CI – pre-commit run --all-files and
    pytest providers/git/tests/unit/git/bundles/test_git.py both pass.

Notes

This change only touches airflow.providers.git.bundles.git.GitDagBundle
and has no effect on other bundles or on cases where
supports_versioning=False.

Closes #52040

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jun 24, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:providers provider:git
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitDagBundle: DAG processor fails to load versioned DAGs due to missing materialized folders
1 participant
@liyude-tw