-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Force the definition of execution_api_server_url
based on api_url
#52184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force the definition of execution_api_server_url
based on api_url
#52184
Conversation
The Tests AMD / CI image checks / MyPy checks (mypy-providers) (pull_request) is failure has nothing to do with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Code looks good but in details it fails in "complexity" in which order the modules are loaded. I assume you rather need to set config in a try/catch not via if
.
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py
Outdated
Show resolved
Hide resolved
I'm not sure an That’s why
There’s also a scenario where the user explicitly sets So in my opinion, this comes down to an implementation decision: |
@jscheffl Another alternative would be to insert the logic in
|
Yeah you are right. Implementation decision. Such hard thoughts needed. I agree the chicken egg is existing. I assume there will be cases in the future where you might want to separate API server from task SDK API. Therefore I always kept it separate. The Actually the idea to inject in |
@jscheffl I moved the implementation code to |
As you made WIP commits, converting the PR to "Draft". Let me know if I should re-review. |
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Force the definition of
execution_api_server_url
based onapi_url
This change ensures that the
execution_api_server_url
is automatically derived fromapi_url
when not explicitly set. It supports compatibility with both Airflow 2 (internal API) and Airflow 3+ (execution API) without requiring implicit configuration.Related: #52082
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.