-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Add deprecation to airflow/sensors/base.py
#52178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Had to todo earlier, resolved that.
This reverts commit 54f9bff.
This one breaks main as some providers import from airlfow.sensors still. This should be redone with all-tests-needed. Reverting it for now. |
Example failure here: https://github.com/apache/airflow/actions/runs/15859739494 @kaxil - > and actually it's GOOOD that the tests failed because it has revealed that some of our providers (for example http still use those imports. We need to decide what to do in this case - whether to add "min-versions" for those providers in upcoming Airflow 3.1 or keep deprecated attr-based imports - following the regular way we deprecate things. |
Update: I think it's ONLY |
Update 2: I have not realized you actually added deprecations... The problem Really is in the tests - because we are using |
Oh yeah, will fix it. |
Had to todo earlier, resolved that.
Had to todo earlier, resolved that.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.