Skip to content

Add deprecation to airflow/sensors/base.py #52178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 24, 2025

Had to todo earlier, resolved that.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Had to todo earlier, resolved that.
@kaxil kaxil added this to the Airflow 3.1.0 milestone Jun 24, 2025
@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Jun 24, 2025
@kaxil kaxil merged commit 54f9bff into apache:main Jun 24, 2025
55 checks passed
@kaxil kaxil deleted the move-base-sensor-compat branch June 24, 2025 18:23
potiuk added a commit to potiuk/airflow that referenced this pull request Jun 24, 2025
@potiuk
Copy link
Member

potiuk commented Jun 24, 2025

This one breaks main as some providers import from airlfow.sensors still. This should be redone with all-tests-needed. Reverting it for now.

potiuk added a commit that referenced this pull request Jun 24, 2025
@potiuk
Copy link
Member

potiuk commented Jun 24, 2025

Example failure here: https://github.com/apache/airflow/actions/runs/15859739494

@kaxil - > and actually it's GOOOD that the tests failed because it has revealed that some of our providers (for example http still use those imports. We need to decide what to do in this case - whether to add "min-versions" for those providers in upcoming Airflow 3.1 or keep deprecated attr-based imports - following the regular way we deprecate things.

@potiuk
Copy link
Member

potiuk commented Jun 24, 2025

Update: I think it's ONLY http - but because it is used transitively by other providers, it looked like it's more.

@potiuk
Copy link
Member

potiuk commented Jun 24, 2025

Update 2: I have not realized you actually added deprecations... The problem Really is in the tests - because we are using mock and it does not understand our deprecation mechanism... So it looks like things will work fine once we also fix the imports in tests :D

@kaxil
Copy link
Member Author

kaxil commented Jun 25, 2025

Update 2: I have not realized you actually added deprecations... The problem Really is in the tests - because we are using mock and it does not understand our deprecation mechanism... So it looks like things will work fine once we also fix the imports in tests :D

Oh yeah, will fix it.

kaxil added a commit to astronomer/airflow that referenced this pull request Jun 25, 2025
Had to todo earlier, resolved that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants