[v3-0-test] fix mypy errors in otel_tracer (#52170) #52175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c6693cb) Co-authored-by: Christos Bisias <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes mypy errors in the otel_tracer module by updating function return types and the corresponding implementation.
- Added an import for AbstractContextManager to support the new return type.
- Updated the _new_span function signature and its implementation to return either a context manager or a span object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c6693cb)
Co-authored-by: Christos Bisias [email protected]