Skip to content

Airbyte test fixes, make mock JobResponse response id as int #52134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented Jun 24, 2025

As per airbyte_api model, the job id is int type https://github.com/airbytehq/airbyte-api-python-sdk/blob/main/src/airbyte_api/models/jobresponse.py#L17

Updating tests to align model.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@gopidesupavan gopidesupavan changed the title Fix airbyte mock response type Airbyte test fixes, make mock JobResponse response id as int Jun 24, 2025
@gopidesupavan gopidesupavan force-pushed the fix-airbyte-mock-response-type branch from 926e907 to 598cf6f Compare June 24, 2025 12:19
@gopidesupavan gopidesupavan requested a review from jscheffl June 24, 2025 21:54
@amoghrajesh
Copy link
Contributor

@gopidesupavan could you add description to the PR? Why are we fixing this?

@gopidesupavan
Copy link
Member Author

@gopidesupavan could you add description to the PR? Why are we fixing this?

updated.

@gopidesupavan gopidesupavan merged commit 84c4fca into apache:main Jun 25, 2025
68 checks passed
@gopidesupavan gopidesupavan deleted the fix-airbyte-mock-response-type branch June 25, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants