Fix: Unclosed aiohttp ClientSession and TCPConnector in DatabricksRunNowOperator (deferrable=True) #52119
+40
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Awesome, @SalikramPaudel. Thank you for the fix. Cannot wait for upgrading to this version :-) |
|
cc: @pankajkoti => since you are working on this operator's Airflow 3 compatibility, maybe you can take a look as well ? |
6fba668 to
ea2ead1
Compare
pankajkoti
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
LGTM. Thanks for your great first contribution @SalikramPaudel 👏🏽
…redentials When using `DatabricksRunNowOperator` with `deferrable=True` and Azure authentication, unclosed aiohttp sessions were reported for both `ClientSecretCredential` and `ManagedIdentityCredential`. This fix ensures that: - `ClientSecretCredential` is used within an `async with` block to auto-close the session safely. - `ManagedIdentityCredential` is also used with `async with` (supported in azure-identity >= 1.7.0b2). This prevents runtime warnings like: - "Unclosed client session" - "Unclosed connector" The fix improves resource handling and aligns with Azure SDK best practices.
…manager flow Production now wraps `azure.identity.aio.ClientSecretCredential` in `async with`, so patching only `__init__`/`get_token` left the real `__aenter__` to explode with “AttributeError: _client”. The tests are refactored to: * Patch the credential class itself instead of individual methods. * Return a fully mocked object that implements `__aenter__`, `__aexit__`, and `get_token`, preserving existing assertions on constructor kwargs and token scope. * Apply the same change to both `TestDatabricksHookAsyncAadTokenOtherClouds` and `TestDatabricksHookAsyncAadTokenSpOutside`. No production code is affected; the update silences the failing async test suites introduced by the resource-cleanup PR.
ea2ead1 to
1d1b4e4
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #51910
What this PR does
Fixes unclosed
aiohttp.ClientSessionandTCPConnectorwarnings when usingDatabricksRunNowOperatorwithdeferrable=Truein Airflow 3.0.2 and Databricks Provider 7.4.0.Background
As described in #51910, the following errors appear during deferrable task execution:
These indicate improper async resource cleanup during trigger polling.
Fix
aiohttp.ClientSessionandTCPConnectorare properly closedStatus
Opening as a Draft PR to allow early feedback.