Add tests to test whether snowflake sql API handles invalid JSON #52118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Jun 24, 2025
2 tasks
eladkal
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #52079. The original issue reported that the Snowflake SQL API codebase attempted to fetch JSON without raising for status, which could result in failures if an error occurred and the JSON was invalid. However, upon closer inspection, I found that this problem was actually addressed about five days ago in PR #51463 (which closed #50514). So, this issue was indirectly fixed.
However, there were no tests to confirm the fix. In this PR, I’ve added two test cases, one for the async and one for the sync API call in the hook. Both tests are passing, which validates that the change works as expected.