Cleanup middlewares #52116
Merged
Cleanup middlewares #52116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1de74a to
dabc30e
Compare
dabc30e to
a41e26c
Compare
Tests are actually right :) I was wrong in my testing (or actually understanding of the middleware), we cannot add the middleware as part of the auth manager. Though, I added a check to verify that the auth manager configured in the environment is SAM. So the intent of the PR did not change. |
pierrejeambrun
approved these changes
Jun 25, 2025
bugraoz93
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 2 middlewares in core Airflow:
SimpleAllAdminMiddleware. Specific to simple auth manager. It should only be added if SAM is configured in the environmentFlaskExceptionsMiddleware. Specific to FAB auth manager. It should only be added if FAB auth manager is configured in the environment. However, when working on this change and testing it, I found out this middleware is not necessary. When removed, the translation of exceptions/status code between Flask and Fastapi was still working without it. I guessWSGIMiddlewarehandles it.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.