-
Notifications
You must be signed in to change notification settings - Fork 15.3k
AIP-90: HITLOperator within standard provider #52053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Lee-W
wants to merge
38
commits into
apache:main
Choose a base branch
from
astronomer:aip-90-within-standard-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,060
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39043d9
to
3b35e89
Compare
2 tasks
e30a6ac
to
c513ced
Compare
1 task
c513ced
to
43506bf
Compare
…t implemented and leave them to follow up PRs
4563a53
to
7f68d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
AIP-90
What
HITLInputRequestModel
: Store the information of body, options, etc.HITLResponseModel
: Human response to an input requestGET /hitl/{task_instance_id}/input-requests
: get an input request created by the TI (should we change it to something like/hitl/task-instance/{task_instance_id}/input-requests
)POST /hitl/{task_instance_id}/response
: write a response to the input request created by the TIGET /hitl/input-requests
: get all input requestsPOST /hitl/{task_instance_id}/input-requests
:HITLOperator
create aHITLInputRequestModel
before deferringGET /hitl/{task_instance_id}/response
: after deferring,HITLTrigger
keeps checking whether the response is readyHITLTerminationOperatordefer to follow up PRsHITLBranchOperatordefer to follow up PRsHITLEntryOperator (not implemented)defer to follow up PRsTODO
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.