Feature/fix xcom push in spark kubernetes operator #52051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
reviewed
Jun 24, 2025
| @@ -293,10 +293,24 @@ def client(self) -> CoreV1Api: | |||
| def custom_obj_api(self) -> CustomObjectsApi: | |||
| return CustomObjectsApi() | |||
|
|
|||
| def update_pod_spec_add_xcom_sidecar(self): | |||
There was a problem hiding this comment.
Suggested change
| def update_pod_spec_add_xcom_sidecar(self): | |
| def update_pod_spec_add_xcom_sidecar(self) -> None: |
| ) | ||
| self.template_body["spark"]["spec"]= driver_with_xcom_template | ||
| except KeyError as e: | ||
| raise AirflowException("Spec missing in SparkApplication template") from e |
There was a problem hiding this comment.
let's not use AirflowException, we can create a customized exception or just use KeyError
There was a problem hiding this comment.
Why?
In all the file, when something doesn't work as expected, an AirflowException is raised
There was a problem hiding this comment.
AirflowException is broad and not infomative
| @@ -46,7 +50,7 @@ class PodDefaults: | |||
|
|
|||
|
|
|||
| def add_xcom_sidecar( | |||
| pod: k8s.V1Pod, | |||
| pod: Union[k8s.V1Pod, dict], | |||
There was a problem hiding this comment.
Suggested change
| pod: Union[k8s.V1Pod, dict], | |
| pod: k8s.V1Pod | dict, |
Lee-W
requested changes
Jun 30, 2025
| ) | ||
| self.template_body["spark"]["spec"]= driver_with_xcom_template | ||
| except KeyError as e: | ||
| raise AirflowException("Spec missing in SparkApplication template") from e |
There was a problem hiding this comment.
AirflowException is broad and not infomative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39184 where SparkKubernetesOperator tasks hang indefinitely because no sidecar is injected to read /airflow/xcom/return.json.