Skip to content

Added support for job launcher #52024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added support for job launcher #52024

wants to merge 4 commits into from

Conversation

rbm897
Copy link

@rbm897 rbm897 commented Jun 22, 2025

closes: #50595


Currently Airflow helm chart only allows Pod launcher. This PR is adding support for Job launcher.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link

boring-cyborg bot commented Jun 22, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jun 22, 2025

Any tests for it?

@rbm897
Copy link
Author

rbm897 commented Jun 24, 2025

Any tests for it?

I'll add and update

@rbm897
Copy link
Author

rbm897 commented Jun 24, 2025

Hi @potiuk I have pushed tests as well. Please help to review.

@rbm897
Copy link
Author

rbm897 commented Jun 25, 2025

@potiuk pre-commit is failing for Generate mocks for go

Generate mocks for go.......................................................Failed

  • hook id: go-mockery
  • exit code: 1

2025-06-25T00:16:38.673328799Z INF Starting mockery config-file=/src/go-sdk/.mockery.yml version=v3.4.0
2025-06-25T00:16:39.011618716Z INF Parsing configured packages... version=v3.4.0
2025-06-25T00:16:47.530646637Z ERR encountered error when loading package error="-: error obtaining VCS status: exit status 128\n\tUse -buildvcs=false to disable VCS stamping." version=v3.4.0
2025-06-25T00:16:47.530715512Z ERR unable to parse packages error="error occurred when loading packages" version=v3.4.0
2025-06-25T00:16:47.530732345Z FTL app failed error="error occurred when loading packages" version=v3.4.0

not sure what I am missing here. Any suggestion pls?

@rbm897
Copy link
Author

rbm897 commented Jun 25, 2025

Hi @potiuk

with export GOFLAGS="-buildvcs=false"

The tests are passing. Please help to review and merge.

@rbm897
Copy link
Author

rbm897 commented Jun 25, 2025

Screenshot 2025-06-26 at 5 25 21 AM

@rbm897
Copy link
Author

rbm897 commented Jun 28, 2025

Hi @potiuk @dstandish @jedcunningham @hussein-awala

Please help to review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubernetesJobOperator is not creating jobs using official chart
2 participants