Add direct-to-triggerer for DataprocSubmitJobOperator #52005
+553
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladaZakharova
suggested changes
Jun 23, 2025
Comment on lines
+263
to
+269
| query = session.query(TaskInstance).filter( | ||
| TaskInstance.dag_id == self.task_instance.dag_id, | ||
| TaskInstance.task_id == self.task_instance.task_id, | ||
| TaskInstance.run_id == self.task_instance.run_id, | ||
| TaskInstance.map_index == self.task_instance.map_index, | ||
| ) | ||
| task_instance = query.one_or_none() |
There was a problem hiding this comment.
This code will not be compatible with AF3. If you were looking for solutions for this functionality, I think it is better to use already existing trigger. If I understand correctly. Can you please show also your system tests results for this code, both for AF2 and AF3 as screenshots? thanks
There was a problem hiding this comment.
Thank you for reviewing.
Actually when i ran system test, it failed so that i should fix the code. And i can't find ref about why the code that you mentioned couldn't be compatible with AF3. Could you give me ref for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #50563
Hi i implemented
start_from_triggerfunction for DataprocSubmitJobOperator. Pls review my pr