-
Notifications
You must be signed in to change notification settings - Fork 15.2k
fix(chart): dag processor and api server scc validation #51814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Wasn't the dag processor part resolved in #51080 ? |
Kinda @eladkal, it depended on whether the {{- if .Values.dagProcessor.enabled }}
- kind: ServiceAccount
name: {{ include "dagProcessor.serviceAccountName" . }}
namespace: "{{ .Release.Namespace }}"
{{- end }} To solve this we need to apply the same logic that’s used in the deployment and service account conditions for the DAG Processor - ref. To test this, just set |
@brancof can you take a look at the failing tests? |
@eladkal I believe the Ref: https://github.com/apache/airflow/actions/runs/15693620873/job/44214695300 Since the changes add the api-server service account reference to the list of subjects (in the Possible solution:
I just don't know if more tests are required because of this (api-server enabled, or webserver enabled). |
While testing Airflow v3 on OpenShift 4.18 using Helm Chart 1.17.0, I encountered some issues.
Since Airflow 3.0.0, both the API Server and DAG Processor are enabled by default. Although this is expected behavior, the deployment fails due to OpenShift’s Security Context Constraints (SCC) restrictions.
To resolve this, the SCC role bindings need to be expanded to properly support all deployment scenarios from Airflow v2 to v3, covering both the API Server and DAG Processor components.