Add TTL-enabled LRU cache for StatsD metrics aggregation #51792
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Some static checks fail.... though I am not an statsd expert... @AutomationDev85 Do you have an opinion to the configs? |
…/shubham36deshpande/airflow into issue-50645-statsd-ttl-lru-cache
jscheffl
reviewed
Jun 28, 2025
jscheffl
reviewed
Jun 30, 2025
Comment on lines
103
to
+108
| {{- else}} | ||
| args: | ||
| - "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml" | ||
| - "--statsd.cache-size={{ .Values.statsd.cacheSize }}" | ||
| - "--statsd.cache-type={{ .Values.statsd.cacheType }}" | ||
| - "--ttl={{ .Values.statsd.ttl }}" |
There was a problem hiding this comment.
On my second pass-review. If .Values.statsd.args is defined this basically means the cacheSize/cacheType and ttl parameters are ignored.
Can you at least add this to the docs or is there a way to append the parameters to the args as well (merge them)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Helm chart
This PR introduces a TTL (time-to-live) mechanism in conjunction with an LRU (least-recently-used) cache for StatsD metric aggregation. The change is designed to automatically clean up stale or unused metric entries, preventing uncontrolled memory growth in long-running statsd daemons—a problem highlighted in issue #50645.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.