-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Introduce workers.celery and workers.kubernetes config sections #51460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Miretpl
wants to merge
18
commits into
apache:main
Choose a base branch
from
Miretpl:separate-workers-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the introduction of |
94a1b5a
to
12ba007
Compare
Both sections |
This was referenced Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #28880
Currently, in the Helm Chart, there is a workers field whose values are shared between Celery and Kubernetes executors workers. The only possible way to configure both separately is by using the
podTemplate
field, which overrides the whole pod-template-file content. However, there is no easy possibility to override part of the configuration or to share the same configuration between workers.This PR introduces the
workers.celery
andworkers.kubernetes
files, which contain specific fields used by each executor worker. Every field specified under the above sections overrides the value of the respective fields under theworkers
section. In case of configuring the field underworkers
section, without configuring different values underworkers.celery
orworkers.kubernetes
sections, it will result in applying the change to both worker types. I added comments about deprecation to every field which was used only by one executor type. Also, I implemented the separation of service accounts used by pod-template-file and Airflow Celery workers with the usage ofworkers.useWorkerDedicatedServiceAccounts
flag. By default, both workers will use a single common service account, and the fieldsworkers.celery.serviceAccount
andworkers.kubernetes.serviceAccount
will have no effect.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.