Skip to content

Fix http exception when ti not found for extra links API #51443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

amoghrajesh
Copy link
Contributor

@amoghrajesh amoghrajesh commented Jun 5, 2025

While working on failing tests on #51297, realised that the exception thrown in extra links API when ti is not found isnt correct.

#51297 will add test coverage for this change.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jun 5, 2025
@amoghrajesh amoghrajesh added the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label Jun 5, 2025
@amoghrajesh amoghrajesh self-assigned this Jun 5, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks, the PR you are mentioning that is supposed to add the test case is not correct I believe.

@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.3 milestone Jun 5, 2025
@amoghrajesh
Copy link
Contributor Author

@pierrejeambrun thanks, corrected it. Copy paste error

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, but the test need fix:

airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_extra_links.py::TestGetExtraLinks::test_should_respond_404[missing_dag_run]

@amoghrajesh
Copy link
Contributor Author

Good call, will do

@amoghrajesh amoghrajesh merged commit ce4e9e8 into apache:main Jun 6, 2025
97 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
…51443)

* Fix http exception when ti not found for extra links API

* no question of dagrun here, remove that test
(cherry picked from commit ce4e9e8)

Co-authored-by: Amogh Desai <[email protected]>
Copy link

github-actions bot commented Jun 6, 2025

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 6, 2025
…pache#51443)

* Fix http exception when ti not found for extra links API

* no question of dagrun here, remove that test
(cherry picked from commit ce4e9e8)

Co-authored-by: Amogh Desai <[email protected]>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Fix http exception when ti not found for extra links API

* no question of dagrun here, remove that test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants