-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Fix http exception when ti not found for extra links API #51443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks, the PR you are mentioning that is supposed to add the test case is not correct I believe.
@pierrejeambrun thanks, corrected it. Copy paste error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, but the test need fix:
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_extra_links.py::TestGetExtraLinks::test_should_respond_404[missing_dag_run]
Good call, will do |
…51443) * Fix http exception when ti not found for extra links API * no question of dagrun here, remove that test (cherry picked from commit ce4e9e8) Co-authored-by: Amogh Desai <[email protected]>
…pache#51443) * Fix http exception when ti not found for extra links API * no question of dagrun here, remove that test (cherry picked from commit ce4e9e8) Co-authored-by: Amogh Desai <[email protected]>
* Fix http exception when ti not found for extra links API * no question of dagrun here, remove that test
While working on failing tests on #51297, realised that the exception thrown in extra links API when ti is not found isnt correct.
#51297 will add test coverage for this change.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.