changing import path to airflow.sdk #50659
Conversation
There was a problem hiding this comment.
We should run this through our system test infra before merging @ramitkataria
|
Good idea, I'll run this soon |
c4df7e8 to
81ce238
Compare
|
@ramitkataria, please let me know if this PR works fine with the system tests infra. |
81ce238 to
7ef0b2f
Compare
|
@Bowrna I ran this through the system tests infra on local executor and most of the tests are passing but there are a few failures, probably not related to this change (there are already some issues in system tests that we're working on fixing). I can't test on remote executor such as ECS executor right now because all the tests are already failing. I don't think this change should cause issues but just to be safe, maybe we should wait until we fix the existing issues? |
|
Sure @ramitkataria, please let me know if I can support you in any way. |
|
I am not sure whether this PR is a good idea. When this is merged you basically break compatibility with Airflow 2.10/2.11 |
Hi @jscheffl , like suggested by @amoghrajesh could i add support for compatibility in import and raise an updated PR. will that work fine? |
I'd leave it up to you. I just wanted to warn that it breaks compatability. But you can also leave the imports as-is until compatability is dropped. |
|
Also, could you please update the branch with main? There have been changes recently that fixed most of the tests |
172c882 to
2cfe83d
Compare
418a4fa to
91d4b46
Compare
@ramitkataria This is done. |
Thanks, I'll run the tests again and let you know |
|
@Bowrna Tests are complete and there were no additional failures so we should be good to merge! |
|
@eladkal @amoghrajesh @o-nikolas @jscheffl |
50d9304 to
c765385
Compare
4c01601 to
10ecb53
Compare
I am not an expert of the Amazon provider, I'd leave the review rather for others. I just stumbled over it and left some comments. |
10ecb53 to
8089933
Compare
|
Could this PR be verified and merged? |
related: #49648
Changes imports in amazon provider to use airflow.sdk
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.