Skip to content

Update pipeline.rst #50422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2-10-test
Choose a base branch
from
Open

Update pipeline.rst #50422

wants to merge 1 commit into from

Conversation

sjairam42
Copy link

Your download statement is for stable when this tutorial is for 2.10.5. If you select stable you will get Airflow 3.0.0

Your download statement is for stable when this tutorial is for 2.10.5.  If you select stable you will get Airflow 3.0.03
@sjairam42 sjairam42 requested a review from potiuk as a code owner May 10, 2025 06:08
Copy link

boring-cyborg bot commented May 10, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change doesn’t fix the documentation of old versions, and for latest, this is expected, as the stable version now is 3.0.0.
I don’t know if we have a clean way to fix/update old documentation

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah your target branch is 2.10, so it should be fine, but maybe you could replace the explicit 2.10.5 by latest Airflow 2 tag

@sjairam42
Copy link
Author

It fixes for the version that most of us are currently using.
Not everyone will move to 3.0.0. As such this page is also a tutorial for 2.10.5 , so having the wrong version brought down with the compose file, doesn't really help.

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer accept changes to 2.10 branch.
I think this doc fix needs to be done manually on the doc site html direclty
cc @gopidesupavan @potiuk

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants