Skip to content

feat: direct configuration of running pod log lines number #49117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: direct configuration of running pod log lines number #49117

wants to merge 2 commits into from

Conversation

insomnes
Copy link
Contributor

@insomnes insomnes commented Apr 11, 2025 •
edited
Loading

  • KubernetesExecutor.RUNNING_POD_LOG_LINES deprecated warning
  • new running_pod_log_lines option in kubernetes_executor section
  • add ability to disable line limit with -1 value
  • expanded tests for logging behavior
  • move other logging tests under single test class

closes: #48710

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Apr 11, 2025
@insomnes insomnes force-pushed the cfg-for-run-pod-log branch 8 times, most recently from 210180a to 6b6e413 Compare April 18, 2025 16:47
@insomnes insomnes force-pushed the cfg-for-run-pod-log branch 8 times, most recently from 083905e to 8f7eea6 Compare April 26, 2025 05:38
@insomnes insomnes force-pushed the cfg-for-run-pod-log branch 2 times, most recently from d12abb4 to 1c0aa31 Compare April 29, 2025 07:50
@eladkal eladkal force-pushed the cfg-for-run-pod-log branch from 1c0aa31 to f852d12 Compare May 11, 2025 06:07
@insomnes insomnes force-pushed the cfg-for-run-pod-log branch from f852d12 to 36a87af Compare May 22, 2025 09:03
@insomnes insomnes force-pushed the cfg-for-run-pod-log branch 2 times, most recently from 073cf3b to a5f53f8 Compare June 3, 2025 09:22
insomnes added 2 commits June 12, 2025 08:30
@insomnes
feat: direct configuration of running pod log lines number
11d6ac5 
- `KubernetesExecutor.RUNNING_POD_LOG_LINES` deprecated warning
- new `running_pod_log_lines` option in `kubernetes_executor` section
- add ability to disable line limit with `-1` value
- expanded tests for logging behavior
@insomnes
test: move other log tests to new test class too
e47672b
@insomnes insomnes force-pushed the cfg-for-run-pod-log branch from a5f53f8 to e47672b Compare June 12, 2025 06:30
@eladkal eladkal requested a review from romsharon98 June 15, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

@romsharon98 romsharon98 Awaiting requested review from romsharon98

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display entire KubernetesExecutor worker pod logs when task is running instead of only the last 100 lines
1 participant
@insomnes