Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

@jason810496 Thank you for the review! Added test to check default split_statements in run method. Not sure if any other tests are needed?

Thank you @bugraoz93 for the direction! This makes total sense! I'm new to contributing to Airflow -- is there any provider example I can follow to add tests?

Thank you @bugraoz93 for the direction! This makes total sense! I'm new to contributing to Airflow -- is there any provider example I can follow to add tests?

The tests depend on the case and in this case, I believe it should be under providers/presto/tests/unit/presto/hooks/test_presto.py.

If you would like specific examples, please take a look at them here. I believe there are examples where file_name is None or filled means overload in this context. So in your case, those overloads should be covered in tests according to their behaviours in the code
Code

Hi, this is my first "contribution", even if it is just a suggestion. I'm clearly new to this, but I was wondering if some users has some statement like

CREATE TABLE example (id INT); -- added ; in a comment. If the split is not "comment zone safe", it may raise an error
INSERT INTO example (id) VALUES (1);
SELECT * FROM 

or "BEGIN; ... COMMIT;" which makes no sense if executed in multiple statements .
As split_statement was initially false, it was behaving correctly, but now it may not behave as expected

I'm not sure if it's a good solution, but providing split_statements = hasattr(sql,'__iter__') would prevent any unexpected behaviour: if it's not a iterable, it would not split. No changes from before the update.

I'm still looking for the split_statement's definition, but I think it is splitting str with semicolon and iterables by their elements, so it might be an intuitive way to code : you use an iterable if you want it to be split, otherwise, you use a single string (for a single statement)

["DESCRIBE ... ;","SELECT ...;","BEGIN; ... ; COMMIT;"] --> split_statement = True
"BEGIN; ... ; COMMIT;" --> split_statement = False

I'm not a native English speaker, so tell me if i'm not easy to understand, and i'll try to explain my point of view.

Good job anyway, you pointed out something interesting.

Thanks to this issue, I learnt some new things like @overload, which I had already encountered in Java but never explored. Java wasn't in my career path, but seeing it in Python made me look for explanations. I'm still learning, and this was a great opportunity to expand my beginner knowledge.

See you !

Hi, @willshen99 it seems like this PR has been inactive for a while. Could I help with this?

Hi, @willshen99 it seems like this PR has been inactive for a while. Could I help with this?

Feel free to create a new one :)

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@willshen99 if you can rebase and resolve conflicts I think we can merge this PR after tests passes

@eladkal Thanks for the review! I have resolved conflicts.

Tests are failing

Fixed the missing import. Sorry about that.

I think we should have a test in Trino and Presto to make sure that when you can change split_statements to false when using SQLExecuteQueryOperator. WDYT?

@eladkal Thanks for the suggestion. This makes total sense! I'm new to airflow project, and I need some help on adding test cases. I don't think the test case I added work as expected.

You need to enable pre-commits so it will automaticly fix static checks probelms like wrong import order. Check the contribution guide, it explain how to enable it

Some of the tests arw also failing:

FAILED providers/trino/tests/unit/trino/hooks/test_trino.py::TestTrinoHook::test_run - AssertionError: expected call not found.
Expected: run('SELECT 1', False, ('hello', 'world'), <class 'list'>, split_statements=True)
Actual: run('SELECT 1', False, ('hello', 'world'), <class 'list'>)

pytest introspection follows:

Kwargs:
assert equals failed
  {}                           {'split_statements': True}