Skip to content

Remove unused _parse_version function #36450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Dec 27, 2023

This function remain after removal backcompat with older Airflow:


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers area:secrets provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues labels Dec 27, 2023
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taragolis Taragolis force-pushed the unused-code-in-secrets-managers branch from 718353a to 0f0b814 Compare December 27, 2023 14:26
@Taragolis Taragolis changed the title Remove unused _parsed_version function Remove unused _parse_version function Dec 27, 2023
@Taragolis Taragolis added the type:misc/internal Changelog: Misc changes that should appear in change log label Dec 27, 2023
@potiuk potiuk merged commit 9e55f51 into apache:main Dec 27, 2023
@Taragolis Taragolis deleted the unused-code-in-secrets-managers branch December 27, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:secrets provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants