Optimize deferrable mode execution for DataprocSubmitJobOperator
#31317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
reviewed
May 16, 2023
Comment on lines
2033
to
2041
| job = self.hook.get_job(project_id=self.project_id, region=self.region, job_id=self.job_id) | ||
| state = job.status.state | ||
| if state == JobStatus.State.DONE: | ||
| return self.job_id | ||
| elif state == JobStatus.State.ERROR: | ||
| raise AirflowException(f"Job failed:\n{job}") | ||
| elif state == JobStatus.State.CANCELLED: | ||
| raise AirflowException(f"Job was cancelled:\n{job}") | ||
|
|
There was a problem hiding this comment.
Shouldn't this only be in the defer path? Otherwise it would seem it is duplicative.
And then might be nice to shove this code into a private method too.
e.g.
if self.deferrable:
job_id = self._check_before_defer(...)
if job_id:
return job_id
self.defer(
trigger=DataprocSubmitTrigger(There was a problem hiding this comment.
moved the code under self.deferrable condition
cb73892 to
2352117
Compare
potiuk
approved these changes
Jun 4, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR verifies if a dataproc job has already completed (or) errored out (or) cancelled before deferring the task to prevent unnecessary deferring. This way, we can skip deferring the task if it has already been finished.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.