merge BigQueryTableExistenceAsyncSensor into BigQueryTableExistenceSensor #30235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableExistenceAsyncSensor to BigQueryTableExistenceSensor
…or deferrable mode and BigQueryTableExistenceAsyncSensor deprecation
…or when its deferrable attribute is set to True
Lee-W
commented
Mar 22, 2023
|
@uranusjr Does it timeout again? If so, could you please help rerun it? Thanks! |
…igQueryTableExistenceSensor
|
@uranusjr The CI passes now. Could you please take a look when you're available? Thanks! |
uranusjr
approved these changes
Mar 30, 2023
potiuk
approved these changes
Mar 30, 2023
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why making this change?
apache-airflow-providers-google treats the deferred execution of its operators and sensors differently, which might cause confusion. For example, BigQueryCheckOperator uses the deferrable parameter to toggle deferred execution while we need to use another sensor for BigQueryTableExistenceSensor (i.e., BigQueryTableExistenceAsyncSensor) to achieve the same thing.
What's changed?
In this pull request, I move the deferred logic from BigQueryTableExistenceAsyncSensor to BigQueryTablePartitionExistenceSensor so that we can keep the consistency and reduce maintenance effort. Instead of removing BigQueryTableExistenceAsyncSensor, I add a deprecation warning in case users're using it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.