Skip to content

Keyfile dict can be dict not str #29135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Conversation

dstandish
Copy link
Contributor

This makes it much easier to define a connection with json. We can do this:

{"extra": {"keyfile_dict": {"foo": "bar", "private_key": "hi"}}}

Instead of this:

{"extra": {"keyfile_dict": "{\"foo\": \"bar\", \"private_key\": \"hi\"}"}}

This makes it much easier to define a connection with json.  We can do this:

```json
{"extra": {"keyfile_dict": {"foo": "bar", "private_key": "hi"}}}
```

Instead of this:

```json
{"extra": {"keyfile_dict": "{\"foo\": \"bar\", \"private_key\": \"hi\"}"}}
```

I.e. instead of json-dumping the contents of the key first, we can just paste the key as is into the "keyfile_dict" field in extra.
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 24, 2023
@dstandish dstandish merged commit cf90a1a into apache:main Jan 25, 2023
@dstandish dstandish deleted the allow-json-extra branch January 25, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants