Fix mypy errors for google.cloud_build #20234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very small :) |
uranusjr
reviewed
Dec 15, 2021
dbdb5a3 to
f06a9ee
Compare
|
Waaay nicer now ! |
f06a9ee to
a920463
Compare
|
Looking for review |
josh-fell
reviewed
Dec 17, 2021
a920463 to
0b45a0a
Compare
uranusjr
reviewed
Dec 17, 2021
0b45a0a to
1d5038a
Compare
|
Should be fixed now! |
|
The waring in snowflake provider wil be fixed by #20395 |
b17b26a to
46abdbc
Compare
46abdbc to
acfbd37
Compare
|
Two to go to complete google MyPY this and #20329 ! |
acfbd37 to
1668be3
Compare
1668be3 to
338465f
Compare
338465f to
302ec03
Compare
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19891
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.