Skip to content

feat(http): add warning when withCredentials overrides explicit crede… #62383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(http): add warning when withCredentials overrides explicit crede… #62383

wants to merge 1 commit into from
+26 −2

Conversation

SkyZeroZx
Copy link
Contributor

Since merged PR : #62354

Add warning for withCredentials override

What changed:

  • Added dev warning when both withCredentials: true and credentials are set
  • New error code: WITH_CREDENTIALS_OVERRIDES_EXPLICIT_CREDENTIALS
  • Warning only shows in development mode

@pullapprove pullapprove bot requested a review from alxhub June 30, 2025 19:03
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: common/http Issues related to HTTP and HTTP Client labels Jun 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 30, 2025
@SkyZeroZx SkyZeroZx mentioned this pull request Jul 1, 2025
Closed
14 tasks
thePunderWoman
thePunderWoman approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for all these HttpClient improvements!

reviewed-for: fw-general, public-api

@pullapprove pullapprove bot requested review from AndrewKushnir and atscott July 1, 2025 07:18
@thePunderWoman thePunderWoman added the target: minor This PR is targeted for the next minor release label Jul 1, 2025
@SkyZeroZx @thePunderWoman
feat(http): add warning when withCredentials overrides explicit crede…
e9ba323 
…ntials

This will prevent confusion and accidentally overriding of credentials.
@thePunderWoman thePunderWoman force-pushed the http-credentials-warning-message branch from 75fddee to e9ba323 Compare July 1, 2025 07:22
crisbeto
crisbeto approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Jul 1, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit cfbbb08.

The changes were merged into the following branches: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@SkyZeroZx @thePunderWoman @crisbeto