-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isOffloaded method to query AudioTrack offload state. #134
Comments
Potentially also, allow an offload only mode DefaultSudioSink.OFFLOAD_MODE_ENABLED_ONLY ? Similar to #133, there are cases where offload can get disabled (a write error) or other app takes over (TBC?) and we end up playing in SW mode and no way to revert back to offload enabled, until we reconfigure. |
I think we agreed I'd put up a speculative CL with just
and another one that avoids the disabling retry on a write error. Speculative as in, no issue if we decide not to proceed. |
Offload integration is still experimental for now and doesn't expose all the configuration needed.
|
Use case description
The current interface doesn't provide actual status of offload (whether is enabled on the AudioTrack, not whether it's sleeping). It doesn't allow apps making decisions to keep using offload support after a write error, which may be transient.
Requests:
Proposed solution
Add additional methods to AudioOffloadListener that affect the
Alternatives considered
Expose AudioTrack and additional logging.
The text was updated successfully, but these errors were encountered: