Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy is failing #28

Closed
shunkakinoki opened this issue Aug 7, 2020 · 6 comments · Fixed by #29
Closed

Deploy is failing #28

shunkakinoki opened this issue Aug 7, 2020 · 6 comments · Fixed by #29

Comments

@shunkakinoki
Copy link
Contributor

Thanks for the awesome action!
seriously one of my most beloved github actions out there.

The deploy started failing about several hours ago, perhaps an API change on vercel's part?

Error! An unexpected error occurred in inspect: TypeError: Cannot read property 'split' of undefined
@johnmurphy01
Copy link

Having the same issue when deploying my branch deploy

@facosta0787
Copy link

I'm getting the same error
image

but the weird part is that the deployment in vercel finishes succesfully.

image

@EvanLovely EvanLovely mentioned this issue Aug 7, 2020
Closed
@lukasholzer
Copy link

Same here:

image

@jackguoAtJogg jackguoAtJogg mentioned this issue Aug 9, 2020
Closed
@arpanlaha
Copy link

arpanlaha commented Aug 9, 2020 •
edited

It seems to be this line that's causing the issue, as it calls split on alias-domains unconditionally even though alias-domains is intended to be optional. never mind, missing values return empty strings for getInput.

@EvanLovely EvanLovely mentioned this issue Aug 10, 2020
Merged
@amondnet amondnet linked a pull request Aug 12, 2020 that will close this issue
Fix latest "inspect" bug by adding manual Vercel Project Name option #29
Merged
@amondnet
Copy link
Owner

closed by #29

@amondnet amondnet mentioned this issue Aug 13, 2020
Closed
@amondnet amondnet mentioned this issue Aug 22, 2020
Open
@holylander
Copy link

thanks for this :)
I noticed that using the action param vercel-project-name solved the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix latest "inspect" bug by adding manual Vercel Project Name option EvanLovely/vercel-action
7 participants
@amondnet @holylander @johnmurphy01 @lukasholzer @facosta0787 @arpanlaha @shunkakinoki