Skip to content

[UnifiedPDF] [iOS] Page number indicator label is too light #47416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

[UnifiedPDF] [iOS] Page number indicator label is too light #47416

merged 1 commit into from
Jul 1, 2025
+0 −2

Conversation

aprotyas
Copy link
Member

@aprotyas aprotyas commented Jul 1, 2025 •
edited by webkit-early-warning-system
Loading

010630a

[UnifiedPDF] [iOS] Page number indicator label is too light
https://bugs.webkit.org/show_bug.cgi?id=295250
rdar://154711954

Reviewed by Tim Horton.

We currently make the label only 40% opaque. This needlessly hampers the
legibility of said label. Let's not do that.

* Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.mm:
(-[WKPDFPageNumberIndicator initWithFrame:view:pageCount:]):

Canonical link: https://commits.webkit.org/296842@main

b948e5d

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge   🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@aprotyas aprotyas requested a review from cdumez as a code owner July 1, 2025 00:26
@aprotyas aprotyas self-assigned this Jul 1, 2025
@aprotyas aprotyas added the PDF For bugs in WebKit's built-in PDF support. label Jul 1, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 1, 2025 •
edited
Loading

EWS run on current version of this PR (hash b948e5d)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge   🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@aprotyas
Copy link
Member Author

aprotyas commented Jul 1, 2025

Thanks for the review!

@aprotyas aprotyas added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 1, 2025
@aprotyas
[UnifiedPDF] [iOS] Page number indicator label is too light
010630a 
https://bugs.webkit.org/show_bug.cgi?id=295250
rdar://154711954

Reviewed by Tim Horton.

We currently make the label only 40% opaque. This needlessly hampers the
legibility of said label. Let's not do that.

* Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.mm:
(-[WKPDFPageNumberIndicator initWithFrame:view:pageCount:]):

Canonical link: https://commits.webkit.org/296842@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296842@main (010630a): https://commits.webkit.org/296842@main

Reviewed commits have been landed. Closing PR #47416 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 010630a into WebKit:main Jul 1, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 1, 2025
@aprotyas aprotyas deleted the eng/295250 branch July 1, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@aprotyas aprotyas

Labels
PDF For bugs in WebKit's built-in PDF support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aprotyas @webkit-early-warning-system @webkit-commit-queue @hortont424