Skip to content

REGRESSION (294690@main): http/tests/navigation/keyboard-events-during-provisional-navigation is a constant failure #47413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

REGRESSION (294690@main): http/tests/navigation/keyboard-events-during-provisional-navigation is a constant failure #47413

merged 1 commit into from
Jul 1, 2025
+0 −50

Conversation

charliewolfe
Copy link
Member

@charliewolfe charliewolfe commented Jul 1, 2025 •
edited by webkit-early-warning-system
Loading

cbc6e3a

REGRESSION (294690@main): `http/tests/navigation/keyboard-events-during-provisional-navigation` is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=295247
rdar://154712299

Reviewed by Pascoe.

This test is dependent on timing and has needed to be updated several times following Safe Browsing
changes. See 209159@main for example.

* LayoutTests/platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Removed.

Canonical link: https://commits.webkit.org/296843@main

81deee2

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@charliewolfe charliewolfe self-assigned this Jul 1, 2025
@charliewolfe charliewolfe added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jul 1, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 1, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 34e6e8f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@charliewolfe charliewolfe force-pushed the eng/REGRESSION-294690-main-http-tests-navigation-keyboard-events-during-provisional-navigation-is-a-constant-failure branch from 34e6e8f to 81deee2 Compare July 1, 2025 00:31
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 1, 2025 •
edited
Loading

EWS run on current version of this PR (hash 81deee2)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@charliewolfe charliewolfe added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 1, 2025
@charliewolfe
REGRESSION (294690@main): `http/tests/navigation/keyboard-events-duri…
cbc6e3a 
…ng-provisional-navigation` is a constant failure

https://bugs.webkit.org/show_bug.cgi?id=295247
rdar://154712299

Reviewed by Pascoe.

This test is dependent on timing and has needed to be updated several times following Safe Browsing
changes. See 209159@main for example.

* LayoutTests/platform/mac-wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Removed.

Canonical link: https://commits.webkit.org/296843@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-294690-main-http-tests-navigation-keyboard-events-during-provisional-navigation-is-a-constant-failure branch from 81deee2 to cbc6e3a Compare July 1, 2025 00:58
@webkit-commit-queue
Copy link
Collaborator

Committed 296843@main (cbc6e3a): https://commits.webkit.org/296843@main

Reviewed commits have been landed. Closing PR #47413 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cbc6e3a into WebKit:main Jul 1, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascoej pascoej pascoej approved these changes

Assignees

@charliewolfe charliewolfe

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charliewolfe @webkit-early-warning-system @webkit-commit-queue @pascoej