Remove _UIFindInteraction staging. #47410
Merged
+3
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash f27a010) |
aprotyas
reviewed
Jul 1, 2025
Comment on lines
-103
to
-117
| #if HAVE(UIFINDINTERACTION) | ||
|
|
||
| @interface _UIFindInteraction : NSObject <UIInteraction> | ||
| @end | ||
|
|
||
| @interface _UIFindInteraction (Staging_84486967) | ||
|
|
||
| - (void)presentFindNavigatorShowingReplace:(BOOL)replaceVisible; | ||
|
|
||
| - (void)findNext; | ||
| - (void)findPrevious; | ||
|
|
||
| @end | ||
|
|
||
| #endif // HAVE(UIFINDINTERACTION) |
There was a problem hiding this comment.
I think we'll still need this to support open source iOS builds
There was a problem hiding this comment.
We can certainly not call the interface Staging anymore though! but we will need to maintain this in #else // USE(APPLE_INTERNAL_SDK)
#if HAVE(UIFINDINTERACTION)
@interface _UIFindInteraction : NSObject <UIInteraction>
- (void)presentFindNavigatorShowingReplace:(BOOL)replaceVisible;
- (void)findNext;
- (void)findPrevious;
@end
#endifThere was a problem hiding this comment.
Actually, it looks like we only use presentFindNavigatorShowingReplace in our test code, so this should suffice:
#if HAVE(UIFINDINTERACTION)
@interface _UIFindInteraction : NSObject <UIInteraction>
- (void)presentFindNavigatorShowingReplace:(BOOL)replaceVisible;
@end
#endif
aprotyas
approved these changes
Jul 1, 2025
f27a010 to
3bf8639
Compare
|
EWS run on current version of this PR (hash 3bf8639) |
https://bugs.webkit.org/show_bug.cgi?id=295245 rdar://154711569 Reviewed by Abrar Rahman Protyasha. Removing old staging code. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Tools/TestRunnerShared/spi/UIKitSPIForTesting.h: Canonical link: https://commits.webkit.org/296851@main
3bf8639 to
f8d126a
Compare
|
Committed 296851@main (f8d126a): https://commits.webkit.org/296851@main Reviewed commits have been landed. Closing PR #47410 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f8d126a
3bf8639