Skip to content

[commits.webkit.org] "Copy Link" button feels slow due to its commit validation behavior #47408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[commits.webkit.org] "Copy Link" button feels slow due to its commit validation behavior #47408

wants to merge 1 commit into from
+12 −4

Conversation

briannafan
Copy link
Contributor

@briannafan briannafan commented Jun 30, 2025 •
edited by webkit-early-warning-system
Loading

3a081c9

[commits.webkit.org] "Copy Link" button feels slow due to its commit validation behavior
rdar://144348929
https://bugs.webkit.org/show_bug.cgi?id=287205

Reviewed by NOBODY (OOPS!).

Add an option to generate a comparision link without validation.
Then, when 'Copy Link' is pressed, we can return a naive link generated from user input
and output a well-formatted link when the validation is complete.

* Tools/Scripts/libraries/reporelaypy/reporelaypy/static/js/search.js:
(GenerateCompareLink):
(CopyCompareLink):
(CompareRedirect):

3a081c9

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@briannafan
[commits.webkit.org] "Copy Link" button feels slow due to its commit …
3a081c9 
…validation behavior

rdar://144348929
https://bugs.webkit.org/show_bug.cgi?id=287205

Reviewed by NOBODY (OOPS!).

Add an option to generate a comparision link without validation.
Then, when 'Copy Link' is pressed, we can return a naive link generated from user input
and output a well-formatted link when the validation is complete.

* Tools/Scripts/libraries/reporelaypy/reporelaypy/static/js/search.js:
(GenerateCompareLink):
(CopyCompareLink):
(CompareRedirect):
@briannafan briannafan self-assigned this Jun 30, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3a081c9)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@briannafan briannafan requested a review from facetothefate June 30, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@gsnedders gsnedders Awaiting requested review from gsnedders gsnedders is a code owner

@facetothefate facetothefate Awaiting requested review from facetothefate

Assignees

@briannafan briannafan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briannafan @webkit-early-warning-system