Skip to content

[GLib] Re-add API test for WebKitSettings::enable-dns-prefetching removed in 290327@main #47405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

[GLib] Re-add API test for WebKitSettings::enable-dns-prefetching removed in 290327@main #47405

merged 1 commit into from
Jul 1, 2025
+10 −0

Conversation

aperezdc
Copy link
Contributor

@aperezdc aperezdc commented Jun 30, 2025 •
edited by webkit-early-warning-system
Loading

9addd4c

[GLib] Re-add API test for WebKitSettings::enable-dns-prefetching removed in 290327@main
https://bugs.webkit.org/show_bug.cgi?id=295235

Reviewed by Anne van Kesteren.

Bring back the test case for the WebKitSettings::enable-dns-prefetching
property, but taking into account that trying to change it is a no-op
and the option is always disabled.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

Canonical link: https://commits.webkit.org/296857@main

3824e50

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aperezdc aperezdc requested a review from a team as a code owner June 30, 2025 22:50
@aperezdc aperezdc self-assigned this Jun 30, 2025
@aperezdc aperezdc added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 30, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3824e50)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aperezdc aperezdc mentioned this pull request Jun 30, 2025
Merged
@aperezdc aperezdc requested a review from annevk June 30, 2025 22:52
@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 1, 2025
@aperezdc
[GLib] Re-add API test for WebKitSettings::enable-dns-prefetching rem…
9addd4c 
…oved in 290327@main

https://bugs.webkit.org/show_bug.cgi?id=295235

Reviewed by Anne van Kesteren.

Bring back the test case for the WebKitSettings::enable-dns-prefetching
property, but taking into account that trying to change it is a no-op
and the option is always disabled.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

Canonical link: https://commits.webkit.org/296857@main
@webkit-commit-queue webkit-commit-queue force-pushed the readd-glib-dns-prefetch-apitest branch from 3824e50 to 9addd4c Compare July 1, 2025 07:13
@webkit-commit-queue
Copy link
Collaborator

Committed 296857@main (9addd4c): https://commits.webkit.org/296857@main

Reviewed commits have been landed. Closing PR #47405 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9addd4c into WebKit:main Jul 1, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 1, 2025
@aperezdc aperezdc deleted the readd-glib-dns-prefetch-apitest branch July 1, 2025 07:27
@aperezdc aperezdc mentioned this pull request Jul 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees

@aperezdc aperezdc

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aperezdc @webkit-early-warning-system @webkit-commit-queue @annevk