Skip to content

Limit RAMification default to LuaJSFight #47404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Limit RAMification default to LuaJSFight #47404

merged 1 commit into from
Jul 1, 2025
+4 −4

Conversation

Andrew-Fryer
Copy link
Contributor

@Andrew-Fryer Andrew-Fryer commented Jun 30, 2025 •
edited by webkit-early-warning-system
Loading

ef6eb21

Limit RAMification default to LuaJSFight
https://bugs.webkit.org/show_bug.cgi?id=295234
rdar://154706064

Reviewed by Dewei Zhu.

Change default value of lua flag in RAMification.py script
to True so that we only run it instead of all suites by default.

* PerformanceTests/JetStream2/RAMification.py:
(parseArgs):
* PerformanceTests/JetStream3/RAMification.py:
(parseArgs):
* Websites/browserbench.org/JetStream2.1/RAMification.py:
(parseArgs):
* Websites/browserbench.org/JetStream2.2/RAMification.py:
(parseArgs):

Canonical link: https://commits.webkit.org/296871@main

8c754be

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Andrew-Fryer Andrew-Fryer self-assigned this Jun 30, 2025
@Andrew-Fryer Andrew-Fryer added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 30, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash 8c754be)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

dewei-zhu
dewei-zhu approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Andrew-Fryer Andrew-Fryer added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jul 1, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jul 1, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61962.

@Andrew-Fryer
Limit RAMification default to LuaJSFight
ef6eb21 
https://bugs.webkit.org/show_bug.cgi?id=295234
rdar://154706064

Reviewed by Dewei Zhu.

Change default value of lua flag in RAMification.py script
to True so that we only run it instead of all suites by default.

* PerformanceTests/JetStream2/RAMification.py:
(parseArgs):
* PerformanceTests/JetStream3/RAMification.py:
(parseArgs):
* Websites/browserbench.org/JetStream2.1/RAMification.py:
(parseArgs):
* Websites/browserbench.org/JetStream2.2/RAMification.py:
(parseArgs):

Canonical link: https://commits.webkit.org/296871@main
@webkit-commit-queue webkit-commit-queue force-pushed the limit_RAMification_default_to_LuaJSFight branch from 8c754be to ef6eb21 Compare July 1, 2025 17:00
@webkit-commit-queue
Copy link
Collaborator

Committed 296871@main (ef6eb21): https://commits.webkit.org/296871@main

Reviewed commits have been landed. Closing PR #47404 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ef6eb21 into WebKit:main Jul 1, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

Assignees

@Andrew-Fryer Andrew-Fryer

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Andrew-Fryer @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @dewei-zhu