Skip to content

Drop deprecated WKSpeechRecognitionPermissionCallbackComplete code in the UI Process C API #47403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop deprecated WKSpeechRecognitionPermissionCallbackComplete code in the UI Process C API #47403

wants to merge 1 commit into from

Conversation

zakariaridouh
Copy link
Contributor

@zakariaridouh zakariaridouh commented Jun 30, 2025 •
edited by webkit-early-warning-system
Loading

cba59e9

Drop deprecated WKSpeechRecognitionPermissionCallbackComplete code in the UI Process C API
https://bugs.webkit.org/show_bug.cgi?id=295232
rdar://154704585

Reviewed by NOBODY (OOPS!).

`WKSpeechRecognitionPermissionCallbackComplete` is no longer needed. This drops code marked with
a `// FIXME: Deprecate and remove this.` two years ago in 260291@main.

* Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp:
(WKSpeechRecognitionPermissionCallbackGetTypeID):
(WKSpeechRecognitionPermissionCallbackComplete): Deleted.
* Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.h:

cba59e9

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zakariaridouh
Drop deprecated WKSpeechRecognitionPermissionCallbackComplete code in…
cba59e9 
… the UI Process C API

https://bugs.webkit.org/show_bug.cgi?id=295232
rdar://154704585

Reviewed by NOBODY (OOPS!).

`WKSpeechRecognitionPermissionCallbackComplete` is no longer needed. This drops code marked with
a `// FIXME: Deprecate and remove this.` two years ago in 260291@main.

* Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp:
(WKSpeechRecognitionPermissionCallbackGetTypeID):
(WKSpeechRecognitionPermissionCallbackComplete): Deleted.
* Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.h:
@zakariaridouh zakariaridouh requested a review from cdumez as a code owner June 30, 2025 22:14
@zakariaridouh zakariaridouh self-assigned this Jun 30, 2025
@zakariaridouh zakariaridouh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 30, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash cba59e9)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

Assignees

@zakariaridouh zakariaridouh

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zakariaridouh @webkit-early-warning-system @cdumez