Skip to content

Many tests failing on WebKitLegacy due to small pixel diff #47400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Many tests failing on WebKitLegacy due to small pixel diff #47400

wants to merge 1 commit into from
+34 −3

Conversation

nmoucht
Copy link
Contributor

@nmoucht nmoucht commented Jun 30, 2025 •
edited by webkit-early-warning-system
Loading

b6cf4a1

Many tests failing on WebKitLegacy due to small pixel diff
https://bugs.webkit.org/show_bug.cgi?id=295231
rdar://154299299

Reviewed by NOBODY (OOPS!).

Hard code scrollbar size for mock scrollbars on wk1.

* Source/WebCore/page/mac/WebCoreFrameView.h:
* Source/WebCore/platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea const):
* Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView initWithCoder:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView verticalScrollbarWidth]):
(-[WebDynamicScrollBarsView horizontalScrollbarHeight]):
* Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsViewInternal.h:

b6cf4a1

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
❌ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ❌ 🛠 playstation
❌ 🛠 tv ✅ 🛠 mac-safer-cpp
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@nmoucht
Many tests failing on WebKitLegacy due to small pixel diff
b6cf4a1 
https://bugs.webkit.org/show_bug.cgi?id=295231
rdar://154299299

Reviewed by NOBODY (OOPS!).

Hard code scrollbar size for mock scrollbars on wk1.

* Source/WebCore/page/mac/WebCoreFrameView.h:
* Source/WebCore/platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformVisibleContentRectIncludingObscuredArea const):
* Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView initWithCoder:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView verticalScrollbarWidth]):
(-[WebDynamicScrollBarsView horizontalScrollbarHeight]):
* Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsViewInternal.h:
@nmoucht nmoucht self-assigned this Jun 30, 2025
@nmoucht nmoucht added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 30, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash b6cf4a1)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
❌ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ❌ 🛠 playstation
❌ 🛠 tv ✅ 🛠 mac-safer-cpp
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez will be requested when the pull request is marked ready for review cdumez is a code owner

Assignees

@nmoucht nmoucht

Labels
merging-blocked Applied to prevent a change from being merged New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmoucht @webkit-early-warning-system @webkit-ews-buildbot