-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Model Element] Model with autoplay sometimes does not play after page reload #47396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
achan00:eng/Model-Element-Model-with-autoplay-sometimes-does-not-play-after-page-reload
Jul 1, 2025
Merged
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash c1b3218) |
c1b3218
to
637da4d
Compare
EWS run on current version of this PR (hash 637da4d) |
mwyrzykowski
approved these changes
Jul 1, 2025
…e reload https://bugs.webkit.org/show_bug.cgi?id=295221 rdar://154646578 Reviewed by Mike Wyrzykowski. This issue happens under a timing condition where the model got suspended before the model process has finished loading it. That can happen if the model process crashes during model load, or if page navigation happens before the model finishes loading. In HTMLModelElement::unloadModelPlayer(), we try to save off the current state of the model player before the deleting the model player, so we can restore to that state when the element is resumed and a new model player is created. However, if the model player hasn't even finished loading when unloadModelPlayer() is called, its animation/transform states won't be valid. Before this fix, the invalid animation state returned has paused=true, so after the model element is resumed and the model player is created with that animation state, it then incorrectly pauses the animation. To fix this, return null for ModelProcessModelPlayer::currentAnimationState() and ModelProcessModelPlayer::currentTransformState() if the model load has not completed successfully. We can tell whether the model load has finished loading by checking for the presence of a non-null m_boundingBoxExtents. * LayoutTests/model-element/model-element-suspend-before-ready-expected.txt: Added. * LayoutTests/model-element/model-element-suspend-before-ready.html: Added. * Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp: (WebKit::ModelProcessModelPlayer::currentAnimationState const): (WebKit::ModelProcessModelPlayer::currentTransformState const): Canonical link: https://commits.webkit.org/296870@main
637da4d
to
1b98465
Compare
Committed 296870@main (1b98465): https://commits.webkit.org/296870@main Reviewed commits have been landed. Closing PR #47396 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebKit Misc.
For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b98465
637da4d