Stop using UncheckedKey containers in WebCore/bindings #47376
Merged
+24
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash fe2ed6e) |
annevk
approved these changes
Jun 30, 2025
https://bugs.webkit.org/show_bug.cgi?id=295205 Reviewed by Anne van Kesteren. Stop using UncheckedKey containers in WebCore/bindings, for safety. This tested as performance neutral on Speedometer. * Source/WebCore/bindings/js/DOMWrapperWorld.h: * Source/WebCore/bindings/js/JSDOMConvertRecord.h: * Source/WebCore/bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::createCrossOriginFunction): (WebCore::JSDOMGlobalObject::createCrossOriginGetterSetter): * Source/WebCore/bindings/js/JSDOMGlobalObject.h: * Source/WebCore/bindings/js/ScriptCachedFrameData.h: * Source/WebCore/bindings/js/ScriptController.h: * Source/WebCore/bindings/js/ScriptModuleLoader.h: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::transferArrayBuffers): (WebCore::containsDuplicates): (WebCore::canOffscreenCanvasesDetach): (WebCore::canDetachRTCDataChannels): (WebCore::canDetachMediaStreamTracks): (WebCore::canDetachMediaSourceHandles): (WebCore::SerializedScriptValue::create): * Source/WebCore/bindings/js/WebCoreJSClientData.h: * Source/WebCore/bindings/js/WindowProxy.h: Canonical link: https://commits.webkit.org/296798@main
fe2ed6e to
b5b9938
Compare
|
Committed 296798@main (b5b9938): https://commits.webkit.org/296798@main Reviewed commits have been landed. Closing PR #47376 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b5b9938
fe2ed6e
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 mac-AS-debug-wk2🧪 gtk-wk2